-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#168 - Experimental JSON CAS support #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reckart
commented
Aug 13, 2021
•
edited
Loading
edited
- Basic JSON CAS support
- Randomized tests
- Added very basic JSON CAS support - No support for type systems yet - No support for lenient loading - Remove Cas:NULL via type name instead of puring simply the FS with ID 0 (which may not be a Cas:NULL fs) - Added various constants for type names and feature names in the Cas class (analouge to the Apache UIMA Java SDK impl) - WIP
- Fixed bad PyDoc comment
* master: No issue: make black
- Fixed linter error because type hint was referring to a dynamically created type
- Roll back change of Sofa.sofaArray range type from uima.cas.ByteArray back to uima.cas.TOP which is indeed the range type also used in the Apache UIMA Java SDK - despite only uima.cas.ByteArray being acceptable...
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 96.15% 95.51% -0.65%
==========================================
Files 4 5 +1
Lines 1509 1827 +318
==========================================
+ Hits 1451 1745 +294
- Misses 58 82 +24
Continue to review full report at Codecov.
|
jcklie
reviewed
Aug 13, 2021
jcklie
reviewed
Aug 13, 2021
jcklie
reviewed
Aug 13, 2021
jcklie
reviewed
Aug 13, 2021
jcklie
reviewed
Aug 13, 2021
tests/test_files/json/fs_as_array/ser-ref/casWithSofaDataArray/data.json
Show resolved
Hide resolved
jcklie
reviewed
Aug 13, 2021
- Added generator for random CASes - Added JSON tests using random CAS generator - Added support for (de)serializing type system information in the JSON format - Move the type/feature name constants from Cas to typesystem.py
- Added another generator for random CASes - Added more tests - Commented out all testing of arrays in the new generator since array handling in cassis seems to have a few conceptual problems when need to be looked at first
- Revert change to stripping the null FS - Changed reference data so that IDs start at 1 and not at 0 leaving 0 reserved for the null FS
* main: #172 - Naming: cas.add_annotation(s) (#181) #175 - Set a feature if the feature name is in a variable (#180) #175 - Set a feature if the feature name is in a variable #174 - FSes that are only transitively referenced cannot be serialized (#179) #170 - Handling of the "uima.noNamespace" prefix (#178) No issue #173 - Rename add_feature to create_feature (#177) # Conflicts: # cassis/typesystem.py
…ed-and-arrays' into feature/168-Experimental-JSON-CAS-support * feature/185-186-187-Handling-of-multipleReferencesAllowed-and-arrays: #187 - The multipleReferencesAllowed flag on array features is not handled #187 - The multipleReferencesAllowed flag on array features is not handled #187 - The multipleReferencesAllowed flag on array features is not handled #187 - The multipleReferencesAllowed flag on array features is not handled #187 - The multipleReferencesAllowed flag on array features is not handled #187 - The multipleReferencesAllowed flag on array features is not handled #186 - Creating subtypes of inheritance-final types (arrays) is not prevented #185 - Transitively referenced primitive arrays not returned by _find_all_fs #186 - Creating subtypes of inheritance-final types (arrays) is not prevented #187 - The multipleReferencesAllowed flag on array features is not handled
- Fix array support - Enable array tests
…ed-and-arrays' into feature/168-Experimental-JSON-CAS-support * feature/185-186-187-Handling-of-multipleReferencesAllowed-and-arrays: #187 - The multipleReferencesAllowed flag on array features is not handled
- Change view members field name
…168-Experimental-JSON-CAS-support * commit '708b78aa5008ec09497999e5655662e5b572d972': #204 - Provide domain on feature
* main: No issue: Dont compute coverage for __version__.py No issue: Dont compute coverage for tests #206 - Type unmarshalling from string to the actual type specified in the type system #206 - Type unmarshalling from string to the actual type specified in the type system #206 - Type unmarshalling from string to the actual type specified in the type system #206 - Type unmarshalling from string to the actual type specified in the type system #204 - Provide domain on feature
- Do not execute performance "tests" when running make test - Update JSON reference data with new data from UIMA Java SDK - including CAS examples using emojis and other Unicode characters - Enabled character offset conversion on import/export in JSON (de)serializer
- Update JSON reference data with new data from UIMA Java SDK - including CAS examples using emojis and other Unicode characters - Enabled character offset conversion on import/export in JSON (de)serializer
…llowed=true fails - Fixed problem by checking the multipleReferencesAllowed feature during deserialization - Added test
- Better check whether adding a TextIOWrapper is necessary during serialization - Fixed bad access to element type name - Formatting
- Better test if using a TextIOWrapper is really necessary
* main: #209 - Parsing an array that was serialized using multipleReferencesAllowed=true fails
reckart
force-pushed
the
feature/168-Experimental-JSON-CAS-support
branch
from
September 20, 2021 15:20
c3c8e58
to
08efad0
Compare
- Work around issues with cas_to_compareble_text and FSArrays
…ithub.com/dkpro/dkpro-cassis into feature/168-Experimental-JSON-CAS-support * 'feature/168-Experimental-JSON-CAS-support' of https://github.com/dkpro/dkpro-cassis: No issue. Formatting. #215 - Ability to exclude types from cas_to_comparable_text #212 - Allow loading/saving XMI/typesystems from/to Path #211 - Serializing an FSArray without any elements breaks #212 - Allow loading/saving XMI/typesystems from/to Path #168 - Experimental JSON CAS support #168 - Experimental JSON CAS support #168 - Experimental JSON CAS support #209 - Parsing an array that was serialized using multipleReferencesAllowed=true fails - Do not execute performance "tests" when running make test - Update JSON reference data with new data from UIMA Java SDK - including CAS examples using emojis and other Unicode characters - Enabled character offset conversion on import/export in JSON (de)serializer #209 - Parsing an array that was serialized using multipleReferencesAllowed=true fails
- Support for floating point special values in JSON - Support for not serializing the full type system in JSON but only the minimal or none at all
* main: No issue. Fix issues with arrays in cas_to_comparable_text. #219 - Floating point special values not serialized as expected
- Run pyupgrade
* main: No issue: Bump version after release No issue: DKPro Cassis 0.6.1 release No issue. Fix PyDoc.
* main: #234 - cas_to_comparable_text fails with null arrays
reckart
force-pushed
the
feature/168-Experimental-JSON-CAS-support
branch
from
December 12, 2021 20:00
397d752
to
9cdd945
Compare
reckart
force-pushed
the
feature/168-Experimental-JSON-CAS-support
branch
from
December 12, 2021 20:06
9cdd945
to
0566e37
Compare
- Added mention about non-final status in README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.